*: support TLS #40
Merged
*: support TLS #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kennytm <kennytm@gmail.com>
kennytm
added
Should Update Ansible
|
PTAL @overvenus @3pointer cc @DanielZhangQD |
overvenus
reviewed
Feb 12, 2020
also added a test to ensure non-TLS-client <-> TLS-server fails. Signed-off-by: kennytm <kennytm@gmail.com>
kennytm
added
status/LGT1
overvenus
approved these changes
Feb 13, 2020
3pointer
approved these changes
Feb 19, 2020
kennytm
added
status/LGT2
kennytm
added a commit
that referenced
this pull request
Feb 28, 2020
* *: support TLS Signed-off-by: kennytm <kennytm@gmail.com> * tests/integrations: make the entire test run on TLS connection also added a test to ensure non-TLS-client <-> TLS-server fails. Signed-off-by: kennytm <kennytm@gmail.com>
kennytm
added a commit
that referenced
this pull request
Mar 2, 2020
* *: support TLS (#40) * *: support TLS Signed-off-by: kennytm <kennytm@gmail.com> * tests/integrations: make the entire test run on TLS connection also added a test to ensure non-TLS-client <-> TLS-server fails. Signed-off-by: kennytm <kennytm@gmail.com> * Cargo.toml: set version to 3.0.11 Signed-off-by: kennytm <kennytm@gmail.com>
52 tasks
3pointer
pushed a commit
to 3pointer/importer
that referenced
this pull request
Apr 2, 2020
* *: support TLS Signed-off-by: kennytm <kennytm@gmail.com> * tests/integrations: make the entire test run on TLS connection also added a test to ensure non-TLS-client <-> TLS-server fails. Signed-off-by: kennytm <kennytm@gmail.com>
3pointer
pushed a commit
to 3pointer/importer
that referenced
this pull request
Apr 2, 2020
* *: support TLS Signed-off-by: kennytm <kennytm@gmail.com> * tests/integrations: make the entire test run on TLS connection also added a test to ensure non-TLS-client <-> TLS-server fails. Signed-off-by: kennytm <kennytm@gmail.com>
kennytm
added a commit
to 3pointer/importer
that referenced
this pull request
Apr 2, 2020
* *: support TLS (tikv#40) * *: support TLS Signed-off-by: kennytm <kennytm@gmail.com> * tests/integrations: make the entire test run on TLS connection also added a test to ensure non-TLS-client <-> TLS-server fails. Signed-off-by: kennytm <kennytm@gmail.com>
3pointer
added a commit
that referenced
this pull request
Apr 2, 2020
* Cherry-pick TLS support to release-3.1 (#44) * *: support TLS (#40) * *: support TLS Signed-off-by: kennytm <kennytm@gmail.com> * tests/integrations: make the entire test run on TLS connection also added a test to ensure non-TLS-client <-> TLS-server fails. Signed-off-by: kennytm <kennytm@gmail.com> * tests: fix build failure Signed-off-by: kennytm <kennytm@gmail.com> Co-authored-by: kennytm <kennytm@gmail.com>
kennytm
removed
the
Should Update Docs
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
Fix #39. Recognize the security config and pass the security manager around when gRPC connections are needed.
What are the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
Manually checked in the TiDB Lightning Integrated Test Cluster.
Does this PR affect TiDB Lightning? (mandatory)
Yes
Refer to a related PR or issue link (optional)
pingcap/tidb-lightning#262
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)