bind the goroutine pool with store and close on Close #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tiancaiamao <tiancaiamao@gmail.com>
Signed-off-by: tiancaiamao <tiancaiamao@gmail.com>
Signed-off-by: tiancaiamao <tiancaiamao@gmail.com>
sticnarf
reviewed
Dec 23, 2022
txnkv/transaction/2pc.go
Outdated
Comment on lines
1015
to
1019
| if gP, ok := c.store.(interface{ Go(func()) }); ok { | ||
| gP.Go(f) | ||
| } else { | ||
| go f() | ||
| } |
There was a problem hiding this comment.
I can imagine the goroutine pool could be used elsewhere. Then, this snippet may be repeated.
So, do you think it acceptable to make Go(func()) a function inside of kvstore? Indeed, this seems a bit strange considering the interface name is kvstore. But kvstore is a private interface, so it will have less worse influence.
Signed-off-by: tiancaiamao <tiancaiamao@gmail.com>
sticnarf
approved these changes
Dec 26, 2022
hawkingrei
pushed a commit
to hawkingrei/client-go
that referenced
this pull request
Feb 24, 2023
Signed-off-by: tiancaiamao <tiancaiamao@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tidb CI
Signed-off-by: tiancaiamao tiancaiamao@gmail.com