Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fit witness #633

Merged
merged 8 commits into from
Jan 9, 2023
Merged

fit witness #633

merged 8 commits into from
Jan 9, 2023

Conversation

ethercflow
Copy link
Member

@ethercflow ethercflow commented Dec 5, 2022 •
edited
Loading

Modify:

  • Skip the witnesses when gen region cache unless the witness is the leader
  • Retry on IsWitness error

ref tikv/tikv#12876

Signed-off-by: Wenbo Zhang ethercflow@gmail.com

@ethercflow
Copy link
Member Author

@Connor1996 PTAL, thanks!

@Connor1996 Connor1996 mentioned this pull request Dec 6, 2022
Open
38 tasks
Connor1996
Connor1996 reviewed Dec 6, 2022
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to cover it in test

@ethercflow ethercflow force-pushed the witness branch 2 times, most recently from 0f3bbcc to 0ba8b34 Compare December 31, 2022 08:45
@ethercflow
Copy link
Member Author

Need to cover it in test

Added, thanks!

@ethercflow
Copy link
Member Author

ethercflow commented Dec 31, 2022 •
edited
Loading

CI failed as need to merge pingcap/kvproto#1031 first.

@ethercflow ethercflow marked this pull request as draft December 31, 2022 14:23
@ethercflow ethercflow marked this pull request as ready for review January 3, 2023 01:59
@ethercflow
fit witness
be315cc 
ref tikv/tikv#12876

Signed-off-by: Wenbo Zhang <ethercflow@gmail.com>
@ethercflow ethercflow force-pushed the witness branch 3 times, most recently from 3524e2e to 82b4995 Compare January 4, 2023 09:11
@ethercflow
update kvproto
2b4ae40 
ref tikv/tikv#12876

Signed-off-by: Wenbo Zhang <ethercflow@gmail.com>
@ethercflow
update integration_tests kvproto
dc8505b 
ref tikv/tikv#12876

Signed-off-by: Wenbo Zhang <ethercflow@gmail.com>
@ethercflow
fix test case
a99c674 
ref tikv/tikv#12876

Signed-off-by: Wenbo Zhang <ethercflow@gmail.com>
@ethercflow
Merge remote-tracking branch 'origin/master'
45ec3a7
@ethercflow
update go.sum
0ef4391 
ref tikv/tikv#12876

Signed-off-by: Wenbo Zhang <ethercflow@gmail.com>
@ethercflow
reverse uncessary change
0a95d14 
ref tikv/tikv#12876

Signed-off-by: Wenbo Zhang <ethercflow@gmail.com>
@ethercflow
fix mismatch dep ver
517aa3a 
ref tikv/tikv#12876

Signed-off-by: Wenbo Zhang <ethercflow@gmail.com>
@ethercflow
Copy link
Member Author

@sticnarf PTAL, thanks!

sticnarf
sticnarf approved these changes Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@sticnarf sticnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sticnarf sticnarf merged commit c20405f into tikv:master Jan 9, 2023
@ethercflow ethercflow mentioned this pull request Jan 9, 2023
Closed
@ethercflow ethercflow deleted the witness branch January 11, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sticnarf sticnarf sticnarf approved these changes

@Connor1996 Connor1996 Awaiting requested review from Connor1996

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ethercflow @Connor1996 @sticnarf