Handle more detailed statistics from TiKV #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sticnarf
force-pushed
the
write-details
branch
8 times, most recently
from
e1de48f to
9076471
Compare
sticnarf
changed the title
sticnarf
force-pushed
the
write-details
branch
3 times, most recently
from
e936633 to
4c208eb
Compare
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
you06
reviewed
Jul 13, 2022
| buf.WriteString(strconv.FormatInt(sd.TotalKeys, 10)) | ||
| } | ||
| if sd.GetSnapshotDuration > 0 { | ||
| buf.WriteString("get_snapshot_time: ") |
There was a problem hiding this comment.
Suggested change
| buf.WriteString("get_snapshot_time: ") | |
| buf.WriteString(", get_snapshot_time: ") |
I'm afraid the not-well formatted output may break some analysis tools.
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
you06
approved these changes
Jul 13, 2022
lcwangchao
added a commit
to lcwangchao/client-go
that referenced
this pull request
Aug 8, 2022
This reverts commit 57c12f7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR collects newly added
WriteDetailand other time details returned from TiKV when handling the most dominant write requests (prewrite, commit and pessimistic lock).