support find stores with tiflash_mpp label #481
Merged
+186
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: guo-shaoge <shaoge1994@163.com>
2 tasks
Signed-off-by: guo-shaoge <shaoge1994@163.com>
|
/hold |
Signed-off-by: guo-shaoge <shaoge1994@163.com>
guo-shaoge
changed the title
XuHuaiyu
reviewed
May 16, 2022
you06
reviewed
May 16, 2022
Signed-off-by: guo-shaoge <shaoge1994@163.com>
12 tasks
|
What about adding counter and duration metrics for the cache invalidation and loading. |
Signed-off-by: guo-shaoge <shaoge1994@163.com>
To keep this pr clean, I will update metrics in the next pr(#509)~ Also |
you06
approved these changes
May 19, 2022
Signed-off-by: guo-shaoge <shaoge1994@163.com>
XuHuaiyu
approved these changes
May 20, 2022
|
/merge |
sticnarf
approved these changes
May 20, 2022
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: guo-shaoge shaoge1994@163.com
close： #498
Related tidb pr: pingcap/tidb#33535
GetTiFlashMPPRPCContextByConsistentHashand its related functions.onSendFail().ctx.Store.storeType == tikvrpc.TiFlashto ctx.Store.storeType.IsTiFlashRelatedType().