config,txnkv: make txnCommitBatchSize adjustable by config #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
I merged a PR yesterday. |
Signed-off-by: Jack Yu <jackysp@gmail.com>
jackysp
force-pushed
the
txn_commit_batch
branch
from
b6f18f6 to
3820ca5
Compare
|
@youjiali1995 it still failed by the same reason after I rebased master. |
disksing
approved these changes
Mar 28, 2022
youjiali1995
approved these changes
Mar 28, 2022
qidi1
pushed a commit
to qidi1/client-go
that referenced
this pull request
Apr 11, 2022
Signed-off-by: Jack Yu <jackysp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jack Yu jackysp@gmail.com
A simple test can provide some benefits such as, for sysbench insert workload, 1pc rate increases.
txnCommitBatchSize = 16k
txnCommitBatchSize = 1M
