fix data race and panic when exiting #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkingrei
force-pushed
the
fix_data_race_when_store_exit
branch
from
5c2f319
to
ccbfb94
Compare
hawkingrei
changed the title
hawkingrei
force-pushed
the
fix_data_race_when_store_exit
branch
4 times, most recently
from
0d18eef
to
a62b671
Compare
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
hawkingrei
force-pushed
the
fix_data_race_when_store_exit
branch
from
a62b671
to
d22c580
Compare
sticnarf
reviewed
Dec 20, 2021
sticnarf
requested changes
Dec 20, 2021
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Weizhen Wang wangweizhen@pingcap.com
When you exit the KVStore, Some task will still call
WaitGroup.Add. It is a dangerous way to make DATA RACE and panic betweenWaitGroup.WaitandWaitGroup.Add.pingcap/tidb#30658
pingcap/tidb#30651