Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: adjust bucket count to reduce metrics data #1609

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

metrics: adjust bucket count to reduce metrics data #1609

wants to merge 2 commits into from
+2 −2

Conversation

zimulala
Copy link

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign marsishandsome for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the dco-signoff: no Indicates the PR's author has not signed dco. label Mar 12, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 12, 2025

Welcome @zimulala!

It looks like this is your first PR to tikv/client-go 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to tikv/client-go. 😃

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 12, 2025
@zimulala zimulala changed the title metrics: adjust some metrics buckets count to reduce metrics data metrics: adjust bucket count to reduce metrics data Mar 12, 2025
zimulala
zimulala commented Mar 12, 2025
View reviewed changes
metrics/metrics.go
@@ -191,7 +191,7 @@ func initMetrics(namespace, subsystem string, constLabels prometheus.Labels) {
Subsystem: subsystem,
Name: "rpc_net_latency_seconds",
Help: "Bucketed histogram of time difference between TiDB and TiKV.",
Buckets: prometheus.ExponentialBuckets(5e-5, 2, 22), // 50us ~ 105s
Buckets: prometheus.ExponentialBuckets(0.0001, 2, 20), // 0.1ms ~ 52s
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a slight adjustment based on https://github.com/tikv/client-go/pull/997/files

@zimulala
metrics: update some metrics buckets info
57a9d17 
Signed-off-by: Lynn <zimu_xia@126.com>
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. dco-signoff: no Indicates the PR's author has not signed dco. and removed dco-signoff: no Indicates the PR's author has not signed dco. dco-signoff: yes Indicates the PR's author has signed the dco. labels Mar 12, 2025
@zimulala zimulala mentioned this pull request Mar 12, 2025
Open
2 tasks
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. and removed dco-signoff: no Indicates the PR's author has not signed dco. labels Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zimulala