-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add txn write conflict metrics #1551
base: master
Are you sure you want to change the base?
Conversation
Welcome @ImSjt! |
/approve zyguan |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ImSjt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please resolve the conflicts
Signed-off-by: sujuntao <juntao.su@foxmail.com>
9dc066e
to
c87174e
Compare
@ekexium PTAL again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I think the metric is not related to lock_resolver. It's more like "WriteConflicts errrors generated from the client side".
Maybe we can remove LockResolverCountWithWriteConflict
and make this one a new metric. What do you think?
@ekexium It makes sense. I think we can add a metrics to count the error results of the doActionOnMutations function, so that we can clearly know the final result of the different actions in the commit phase. What do you think?
|
Have you seen real needs for such metrics? Since metrics are not free, I suggest we either add just one metric for write conflicts or remove the existing one, unless we can justify their value. |
Issue Number: close #1550
Add transaction write conflict metrics.