-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support receving health feedback #1153
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
e714b6a
Register health feedback handler in batch client
MyonKeminta 12166fa
update protocol
MyonKeminta 419649a
Collect the health status and record to the stores
MyonKeminta 9b9d0d0
Remove the filter which looks not necessary
MyonKeminta c381ab5
Add metrics
MyonKeminta cce241a
Fix checkAndUpdateStoreHealthStatus panicking
MyonKeminta f769b67
Add logs
MyonKeminta 3d92daf
Merge SetHealthFeedbackHandler to Client
MyonKeminta a29a129
Try another pattern: separated callback registry
MyonKeminta 1ddc60d
Try region cache eventListener pattern
MyonKeminta 1af7e4a
Add tests
MyonKeminta 3d685e7
Test receiving froim callback
MyonKeminta 91c7bbe
Add tests to region cache
MyonKeminta 903ff59
Remove unnecessary debug log
MyonKeminta daa3dd0
Add comments
MyonKeminta f800ae1
remove replace of tidb repo
MyonKeminta c2509b4
Merge branch 'master' of https://github.com/tikv/client-go into m/rec…
MyonKeminta f99235a
fix build
MyonKeminta 0be8fd6
Update comments; fix lint
MyonKeminta cf5330d
Add the isSlow method of Store back
MyonKeminta c6535a8
remove unused method for now to make lint happy
MyonKeminta eb1421f
Address comments
MyonKeminta 64f11b1
Merge branch 'master' into m/receive-health-feedback
MyonKeminta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just declare that the method is not thread safe and should be called before
SendRequest
so that we can get rid ofatomic.Pointer
and make related code simpler?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but I'm afraid that the assumption might be broken easily by mistake in the future...