levels: don't sync directory in memory mode #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GanZiheng <ganziheng98@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
==========================================
+ Coverage 89.54% 89.63% +0.09%
==========================================
Files 39 39
Lines 8739 8741 +2
==========================================
+ Hits 7825 7835 +10
+ Misses 914 906 -8 |
If we put entries enough to cause compaction in memory mode, we would get this error. I tried to add test for this, but it will result in OOM in memory sanitizer test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will cause problem when performing compaction in memory mode, since we will never return tables built by compaction successfully due to the
sync_dirreturning error with empty path input.Signed-off-by: GanZiheng ganziheng98@gmail.com