ci: Introduce code coverage check (#131)

* introduce code coverage check

Signed-off-by: Connor1996 <zbk602423539@gmail.com>

.github/workflows/test.yml

@@ -24,14 +24,18 @@ jobs:
       - uses: actions/cache@v2
         with:
           path: |
-            ~/.cargo/registry
+            ~/.cargo/bin
+            ~/.cargo/registry/index
+            ~/.cargo/registry/cache
             ~/.cargo/git
+            ~/.cargo/.crates.toml
+            ~/.cargo/.crates2.json
             target
           key: ${{ runner.os }}-cargo-test
       - uses: actions-rs/toolchain@v1
         name: Setup Cargo Toolchain 🛎️
         with:
-          components: rustfmt, clippy
+          components: rustfmt, clippy, llvm-tools-preview
           toolchain: nightly
           default: true
       - name: Check Code Format 🔧
@@ -40,8 +44,14 @@ jobs:
           git diff --quiet
       - name: Linting The Code 🩹
         run: make clippy
-      - name: Running Tests 🚀
-        run: make test
+      - uses: taiki-e/install-action@cargo-llvm-cov      
+      - name: Running Tests With Code Coverage 🚀
+        run: cargo llvm-cov --all-features --workspace --lcov --output-path lcov.info
+      - name: Upload Coverage To Codecov ⬆️
+        uses: codecov/codecov-action@v1 
+        with:
+          files: lcov.info
+          fail_ci_if_error: true
   sanitizer_test:
     name: Test with Sanitizer
     runs-on: ubuntu-latest
@@ -54,8 +64,12 @@ jobs:
       - uses: actions/cache@v2
         with:
           path: |
-            ~/.cargo/registry
+            ~/.cargo/bin
+            ~/.cargo/registry/index
+            ~/.cargo/registry/cache
             ~/.cargo/git
+            ~/.cargo/.crates.toml
+            ~/.cargo/.crates2.json
             target
           key: ${{ runner.os }}-${{ matrix.sanitizer }}-cargo-sanitizer-test
       - uses: actions-rs/toolchain@v1

Makefile

@@ -1,11 +1,7 @@
 
 SANITIZER_FLAGS=-Zsanitizer=address
 
-unset-override:
-	@# unset first in case of any previous overrides
-	@if rustup override list | grep `pwd` > /dev/null; then rustup override unset; fi
-
-pre-format: unset-override
+pre-format:
 	@rustup component add rustfmt
 	@cargo install -q cargo-sort 
 

codecov.yml

@@ -0,0 +1,14 @@
+comment:
+  layout: "diff"
+  behavior: default
+
+coverage:
+  status:
+    project:
+      default:
+        target: auto
+        threshold: 3%
+    patch:
+      default:
+        target: auto
+        threshold: 3%

src/levels.rs

@@ -607,7 +607,7 @@ impl Core {
 
         let mut out = vec![];
 
-        for table in this_level.tables.iter() {
+        for table in &this_level.tables {
             if table.size() >= 2 * compact_def.targets.file_size[0] {
                 // File already big, don't include it.
                 continue;
@@ -668,7 +668,7 @@ impl Core {
         } else {
             let mut kr = KeyRange::default();
             // Start from the oldest file first.
-            for table in this_level.tables.iter() {
+            for table in &this_level.tables {
                 let dkr = get_key_range_single(table);
                 if kr.overlaps_with(&dkr) {
                     out.push(table.clone());
@@ -928,7 +928,8 @@ impl Core {
             if level < start_level {
                 continue;
             }
-            match handler.read()?.get(key) {
+            let v = handler.read()?.get(key);
+            match v {
                 Ok(value) => {
                     if value.value.is_empty() && value.meta == 0 {
                         continue;

src/levels/compaction.rs

@@ -98,12 +98,12 @@ impl KeyRange {
 
     /// Returns `true` if current key range is infinite
     pub fn is_inf(&self) -> bool {
-        return matches!(self, KeyRange::Inf);
+        matches!(self, KeyRange::Inf)
     }
 
     /// Returns `true` if current key range is empty
     pub fn is_empty(&self) -> bool {
-        return matches!(self, KeyRange::Empty);
+        matches!(self, KeyRange::Empty)
     }
 }
 

src/value_log.rs

@@ -1,5 +1,6 @@
 use std::{
     collections::{HashMap, HashSet},
+    iter::FromIterator,
     path::{Path, PathBuf},
     sync::{atomic::AtomicU32, Arc, RwLock},
 };
@@ -153,20 +154,18 @@ impl ValueLog {
     /// Gets sorted valid vlog files' ID set.
     fn sorted_fids(&self) -> Vec<u32> {
         let core = self.core.read().unwrap();
-        let mut to_be_deleted = HashSet::new();
-        for fid in &core.files_to_delete {
-            to_be_deleted.insert(*fid);
-        }
-        let mut result = vec![];
-        for fid in core.files_map.keys() {
-            if !to_be_deleted.contains(fid) {
-                result.push(*fid);
-            }
-        }
+        let to_be_deleted: HashSet<u32> = HashSet::from_iter(core.files_to_delete.iter().cloned());
+        let mut result = core
+            .files_map
+            .keys()
+            .into_iter()
+            .filter(|k| !to_be_deleted.contains(k))
+            .cloned()
+            .collect::<Vec<u32>>();
         // Hold read lock as short as we can
         drop(core);
 
-        // cargo clippy suggests using `sort_ubstable`
+        // cargo clippy suggests using `sort_unstable`
         result.sort_unstable();
         result
     }