forked from open-telemetry/opentelemetry-collector
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Eliminate TESTBED_CONFIG in favor of tests specifying the executable …
…path Contributes to open-telemetry/opentelemetry-collector-contrib#873 We had the concept of a testbed config file that was specified via TESTBED_CONFIG env variable. The idea was that the config file would contain definitions for all tests to use, including the location of the executable to test. Time has shown that we never used anything other than the local.yaml config with one specific location of the executable. We now have the need to allow tests to individually specify different executable. This is needed to run certain tests against the "unstable" executable that contains unstable features (such as Log receivers in the contrib repo). This change eliminates the concept of testbed config and TESTBED_CONFIG env variable. Instead the location of the executable is defined in the TestCase with the default location pointing to the regular "../../bin/otelcol_{{.GOOS}}_{{.GOARCH}}" executable. Individual tests can now override this by setting ChildProcess.AgentExePath to something else if needed. We will use this capability in the contrib testbed.
- Loading branch information
Tigran Najaryan
committed
Oct 28, 2020
1 parent
14618bd
commit cffcf92
Showing
7 changed files
with
53 additions
and
112 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters