devhub: Apply a bit of styling #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabioarnold you'll need to add exceptions for those files to tidy.zig |
|
Hmm - we also probably don't want to have those binary woffs in this repo in any case - could we maybe load them cross-origin from tigerbeetle.com? (I recall you said Google Fonts is out because of GDPR) |
matklad
reviewed
Oct 11, 2024
src/devhub/style/Inter-Bold.woff2
Outdated
There was a problem hiding this comment.
Adding binary fonts to the database repo sounds like a bridge too far to my taste! I'd maybe use built-in fonts, or otherwise loaded them from some kind of CDN with subresource integrity. This is an internal tool, so CDN feels acceptable! (otherwise, I wonder if we could load fonts from our main website? )
|
I got rid of the fonts and exported the logo from Figma to get the text just right (also skewed at the correct angle). |
fabioarnold
force-pushed
the
fabio/devhub-styling
branch
from
3c915f0
to
4f30689
Compare
cb22
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tweaks to fonts, padding, and colors. I added the fonts we use for the website (Inter and Recursive).
Before:
After: