Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add id method #39

Merged
merged 4 commits into from
Dec 18, 2024
Merged

feat: add id method #39

merged 4 commits into from
Dec 18, 2024

Conversation

dyc3
Copy link
Contributor

@dyc3 dyc3 commented Dec 17, 2024 •
edited
Loading

This PR adds the id() method that is present in the official client libraries.

@tyranron tyranron added feature New feature or request k::api Related to API (application interface) labels Dec 18, 2024
@tyranron tyranron added this to the 0.6.0 milestone Dec 18, 2024
tyranron
tyranron approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dyc3 thanks! 🍻

I've reworked your implementation quite a bit to match with upstream ones, since they're doing additional squats to ensure monotonicity.

@tyranron tyranron merged commit aa58866 into tigerbeetle-rust:master Dec 18, 2024
17 checks passed
@dyc3 dyc3 deleted the add-id branch December 18, 2024 16:46
@tyranron
Copy link
Member

@dyc3 released in 0.6.0+0.16.17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@dyc3 dyc3

Labels
feature New feature or request k::api Related to API (application interface)
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dyc3 @tyranron