Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor error module in core crate #29

Merged
merged 5 commits into from
Dec 25, 2024

Conversation

50U10FCA7
Copy link
Contributor

Moved from #24 (comment)

Minor code refactoring and typo fixes.

@50U10FCA7
Copy link
Contributor Author

FCM

Refactor `error` module in `core` crate (#29)

50U10FCA7 added 2 commits November 22, 2024 05:16
@tyranron tyranron force-pushed the master branch 3 times, most recently from 68e7dea to 70ef410 Compare December 2, 2024 17:22
@tyranron tyranron added enhancement New feature or request k::refactor Refactoring, technical debt elimination and other improvements of existing code base labels Dec 25, 2024
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@50U10FCA7 please, sync it with the latest master.

# Conflicts:
#	core/src/error.rs
#	core/src/packet.rs
@50U10FCA7 50U10FCA7 requested a review from tyranron December 25, 2024 11:12
@tyranron tyranron added this to the next milestone Dec 25, 2024
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@50U10FCA7 thanks!

@tyranron tyranron merged commit 7945701 into tigerbeetle-rust:master Dec 25, 2024
17 checks passed
@50U10FCA7 50U10FCA7 deleted the refactor-error-mod branch December 25, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request k::refactor Refactoring, technical debt elimination and other improvements of existing code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants