-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor error
module in core
crate
#29
Merged
tyranron
merged 5 commits into
tigerbeetle-rust:master
from
50U10FCA7:refactor-error-mod
Dec 25, 2024
Merged
Refactor error
module in core
crate
#29
tyranron
merged 5 commits into
tigerbeetle-rust:master
from
50U10FCA7:refactor-error-mod
Dec 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FCMRefactor `error` module in `core` crate (#29) |
# Conflicts: # core/src/error.rs
tyranron
force-pushed
the
master
branch
3 times, most recently
from
December 2, 2024 17:22
68e7dea
to
70ef410
Compare
tyranron
added
enhancement
New feature or request
k::refactor
Refactoring, technical debt elimination and other improvements of existing code base
labels
Dec 25, 2024
tyranron
requested changes
Dec 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@50U10FCA7 please, sync it with the latest master
.
# Conflicts: # core/src/error.rs # core/src/packet.rs
tyranron
approved these changes
Dec 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@50U10FCA7 thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
k::refactor
Refactoring, technical debt elimination and other improvements of existing code base
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved from #24 (comment)
Minor code refactoring and typo fixes.