Fix DNS policy for host-networked pods #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmjd
reviewed
Jul 31, 2020
| if c.installation.Spec.KubernetesProvider == operator.ProviderEKS && | ||
| c.installation.Spec.CNI.Type == operator.PluginCalico { | ||
| // Workaround the fact that webhooks don't work for non-host-networked pods | ||
| // when in this networking mode on EKS, because the control plane nodes don't run | ||
| // Calico. | ||
| hostNetwork = true | ||
| dnsPolicy = corev1.DNSClusterFirstWithHostNet |
There was a problem hiding this comment.
Should we include Otherwise they fail to lookup services within the cluster as a comment here?
tmjd
approved these changes
Jul 31, 2020
caseydavenport
force-pushed
the
casey-fix-hostnet-dns
branch
from
205be3b to
3def5f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Otherwise they fail to lookup services within the cluster
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.