Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calico apiserver improvements #3481

Merged
merged 4 commits into from
Jan 8, 2025
Merged

Calico apiserver improvements #3481

merged 4 commits into from
Jan 8, 2025

Conversation

Tamas-Biro1
Copy link
Contributor

@Tamas-Biro1 Tamas-Biro1 commented Aug 29, 2024 •
edited
Loading

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@marvin-tigera marvin-tigera added this to the v1.36.0 milestone Aug 29, 2024
@CLAassistant
Copy link

CLAassistant commented Aug 29, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Tamas-Biro1 Tamas-Biro1 force-pushed the calico-apiserver-improvements branch 3 times, most recently from 4ee9d6e to 57ec0f3 Compare August 29, 2024 07:46
tmjd
tmjd reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts and use case requests around these changes.

api/v1/apiserver_types.go Outdated Show resolved Hide resolved
api/v1/apiserver_types.go Outdated Show resolved Hide resolved
api/v1/apiserver_types.go Outdated Show resolved Hide resolved
api/v1/apiserver_types.go Outdated Show resolved Hide resolved
@Tamas-Biro1 Tamas-Biro1 force-pushed the calico-apiserver-improvements branch from 57ec0f3 to 2f8a13b Compare August 29, 2024 13:57
@radTuti radTuti modified the milestones: v1.36.0, v1.36.1 Oct 28, 2024
@caseydavenport caseydavenport modified the milestones: v1.36.1, v1.37.0 Oct 28, 2024
@Tamas-Biro1 Tamas-Biro1 force-pushed the calico-apiserver-improvements branch 3 times, most recently from dca69d9 to 657730b Compare November 5, 2024 16:28
@Tamas-Biro1 Tamas-Biro1 marked this pull request as ready for review November 5, 2024 16:31
@Tamas-Biro1 Tamas-Biro1 requested a review from a team as a code owner November 5, 2024 16:31
@Tamas-Biro1 Tamas-Biro1 force-pushed the calico-apiserver-improvements branch from 657730b to 58fe612 Compare November 5, 2024 16:42
@Tamas-Biro1 Tamas-Biro1 requested a review from tmjd November 6, 2024 14:31
@Tamas-Biro1 Tamas-Biro1 force-pushed the calico-apiserver-improvements branch 3 times, most recently from 942c474 to 4a270e3 Compare December 11, 2024 12:54
@radTuti radTuti modified the milestones: v1.37.0, v1.38.0 Dec 13, 2024
tmjd
tmjd reviewed Dec 17, 2024
View reviewed changes
pkg/render/apiserver.go Outdated Show resolved Hide resolved
@Tamas-Biro1 Tamas-Biro1 force-pushed the calico-apiserver-improvements branch 2 times, most recently from 2c2ba82 to b3d2e61 Compare December 18, 2024 14:26
@caseydavenport
Copy link
Member

/sem-approve

@caseydavenport
Copy link
Member

@Tamas-Biro1 A few tests seem to be failing:


Failure
/go/src/github.com/tigera/operator/pkg/render/apiserver_test.go:360
Expected
    <v1.DeploymentStrategyType>: RollingUpdate
to equal
    <v1.DeploymentStrategyType>: Recreate
/go/src/github.com/tigera/operator/pkg/render/apiserver_test.go:197

@Tamas-Biro1
Copy link
Contributor Author

/sem-approve

1 similar comment
@lwr20
Copy link
Member

lwr20 commented Jan 6, 2025

/sem-approve

@Tamas-Biro1 Tamas-Biro1 force-pushed the calico-apiserver-improvements branch from 65d50a3 to 5e5d521 Compare January 6, 2025 16:20
@tmjd
Copy link
Member

tmjd commented Jan 6, 2025

/sem-approve

@Tamas-Biro1 Tamas-Biro1 force-pushed the calico-apiserver-improvements branch from 5e5d521 to 3ba16ac Compare January 7, 2025 08:14
@tmjd
Copy link
Member

tmjd commented Jan 7, 2025

/sem-approve

@Tamas-Biro1 Tamas-Biro1 force-pushed the calico-apiserver-improvements branch from 3ba16ac to a518990 Compare January 7, 2025 16:33
@Tamas-Biro1 Tamas-Biro1 force-pushed the calico-apiserver-improvements branch from a518990 to 439b4fb Compare January 8, 2025 13:55
@tmjd
Copy link
Member

tmjd commented Jan 8, 2025

/sem-approve

@tmjd tmjd merged commit d9ee77d into tigera:master Jan 8, 2025
5 checks passed
@tmjd
Copy link
Member

tmjd commented Jan 8, 2025

Thank you @Tamas-Biro1 for working through this with us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmjd tmjd tmjd left review comments

@caseydavenport caseydavenport caseydavenport approved these changes

Assignees
No one assigned
Labels
docs-pr-required release-note-required
Projects
None yet
Milestone
v1.38.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Tamas-Biro1 @CLAassistant @caseydavenport @lwr20 @tmjd @radTuti @marvin-tigera