Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dockertestx): Support Prism #56

Merged
merged 3 commits into from
Feb 19, 2024
Merged

feat(dockertestx): Support Prism #56

merged 3 commits into from
Feb 19, 2024

Conversation

rxnew
Copy link
Collaborator

@rxnew rxnew commented Feb 18, 2024

Prism support by dockertestx.

dockertestx/prism.go Outdated Show resolved Hide resolved
dockertestx/prism_test.go Outdated Show resolved Hide resolved
Comment on lines -59 to +63
if !ok || !r.Container.State.Running {
// ignore not found or stopped container
if !ok {
continue
}
if !r.Container.State.Running {
_ = pool.Purge(r)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed a problem in which tests fail to run if a container name is specified and there is a stopped container with the same name.

@rxnew rxnew requested a review from sawadashota February 19, 2024 05:51
@rxnew rxnew merged commit 05ab7ef into main Feb 19, 2024
4 checks passed
@rxnew rxnew deleted the feature/dockertestx-prism branch February 19, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants