Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use detected objects instead of predicted ones #712

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Feb 25, 2022

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Types of PR

  • New Features
  • Upgrade of existing features
  • Bugfix

Link to the issue

autowarefoundation/autoware.universe#455

Description

In scenario sim v1, detected objects are published from scenario sim, and perception modules in autoware calculates and publishes tracking, and predicted objects.

However, currently in scenario sim v2, predicted objects are published, where prediction is not calculated and just detected objects are contained. As a result, some scenarios fail.

With this PR, scenario sim v2 publishes detected objects so that autoware can calculate tracking and predicted objects, which will result in failed scenarios passing.

How to review this PR.

Others

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 marked this pull request as ready for review February 25, 2022 08:02
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@yamacir-kit yamacir-kit added the bug Something isn't working label Feb 25, 2022
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 marked this pull request as draft February 28, 2022 07:11
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168
Copy link
Contributor Author

takayuki5168 commented Mar 2, 2022

@yamacir-kit
I confirmed that scenario simulator v2 works with autowarefoundation/autoware.universe#452
Now it's ready for review

@tkimura4
Copy link

tkimura4 commented Apr 7, 2022

@hakuturu583 @yamacir-kit
Is there no problem to merge this PR?

@yamacir-kit
Copy link
Collaborator

yamacir-kit commented Apr 7, 2022

@tkimura4
Yes. Marge will be done by me later today.

@yamacir-kit yamacir-kit merged commit 9891794 into master Apr 8, 2022
@yamacir-kit yamacir-kit deleted the fix/object-recognition-from-prediction-to-detection branch April 8, 2022 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants