Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(pre-commit): add clang-format to keep consistent styles #51

Merged
merged 4 commits into from
Mar 23, 2022

Conversation

kenji-miyake
Copy link
Contributor

This can guarantee that ros_include_guard doesn't conflict with clang-format.

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@@ -1,3 +1,3 @@
#ifndef ROSPKG__NOLINT_HPP_ // NOLINT
#define ROSPKG__NOLINT_HPP_ // NOLINT
#endif // ROSPKG__NOLINT_HPP_ // NOLINT
#endif // ROSPKG__NOLINT_HPP_ // NOLINT
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Add an empty line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added empty lines in f5fb248.

Kenji Miyake added 2 commits March 23, 2022 12:42
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Copy link
Collaborator

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kenji-miyake kenji-miyake merged commit 7502be6 into main Mar 23, 2022
@kenji-miyake kenji-miyake deleted the add-clang-format branch March 23, 2022 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants