Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --xml-whitespace-sensitivity ignore to xml hooks #47

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

kenji-miyake
Copy link
Contributor

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@kenji-miyake
Copy link
Contributor Author

/tmp/autoware_launch main
❯ pre-commit try-repo https://github.com/tier4/pre-commit-hooks-ros prettier-launch-xml -a --ref add-xml-whitespace-sensitivity
===============================================================================
Using config:
===============================================================================
repos:
-   repo: https://github.com/tier4/pre-commit-hooks-ros
    rev: add-xml-whitespace-sensitivity
    hooks:
    -   id: prettier-launch-xml
===============================================================================
[WARNING] The 'rev' field of repo 'https://github.com/tier4/pre-commit-hooks-ros' appears to be a mutable reference (moving tag / branch).  Mutable references are never updated after first install and are not supported.  See https://pre-commit.com/#using-the-latest-version-for-a-repository for more details.  Hint: `pre-commit autoupdate` often fixes this.
[INFO] Initializing environment for https://github.com/tier4/pre-commit-hooks-ros.
[INFO] Initializing environment for https://github.com/tier4/pre-commit-hooks-ros:@prettier/plugin-xml@1.2.0,prettier@2.5.1.
[INFO] Installing environment for https://github.com/tier4/pre-commit-hooks-ros.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
prettier launch.xml......................................................Failed
- hook id: prettier-launch-xml
- files were modified by this hook

autoware_launch/launch/autoware.launch.xml
autoware_launch/launch/logging_simulator.launch.xml



/tmp/autoware_launch main* 6s
❯ git diff
diff --git a/autoware_launch/launch/autoware.launch.xml b/autoware_launch/launch/autoware.launch.xml
index b09380c..9b6271d 100644
--- a/autoware_launch/launch/autoware.launch.xml
+++ b/autoware_launch/launch/autoware.launch.xml
@@ -107,5 +107,4 @@
     <!-- Web Controller -->
     <include file="$(find-pkg-share web_controller)/launch/web_controller.launch.xml"/>
   </group>
-
 </launch>
diff --git a/autoware_launch/launch/logging_simulator.launch.xml b/autoware_launch/launch/logging_simulator.launch.xml
index e775156..c632d0a 100644
--- a/autoware_launch/launch/logging_simulator.launch.xml
+++ b/autoware_launch/launch/logging_simulator.launch.xml
@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <launch>
-
   <!-- Essential parameters -->
   <arg name="map_path" description="point cloud and lanelet2 map directory path"/>
   <arg name="vehicle_model" description="vehicle model name"/>

@kenji-miyake kenji-miyake merged commit c97f757 into main Mar 23, 2022
@kenji-miyake kenji-miyake deleted the add-xml-whitespace-sensitivity branch March 23, 2022 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants