-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: prepare release for v1.1.0 #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… int for account_id
…change SERVER_LOGGING_LEVEL field to Literal field
for more information, see https://pre-commit.ci
Bodong-Yang
changed the title
chore: prepare release for v1.0.1
chore: prepare release for v1.1.0
May 8, 2024
Bodong-Yang
force-pushed
the
release/v1.0.1
branch
from
May 8, 2024 12:47
b6516e5
to
adc4893
Compare
…r tests changed, allow manually trigger
Bodong-Yang
force-pushed
the
release/v1.0.1
branch
from
May 9, 2024 02:35
e41ee39
to
62813bd
Compare
…and filtering is disabled
for more information, see https://pre-commit.ci
This PR introduces the functionality of killing the server on config files changed. Currently the in use ecu_info.yaml, aws_profile_info.yaml and greengrass configuration files are monitored. This feature is expected to be used together with systemd.service Restart policy to achieve automatically restart on config files changed.
for more information, see https://pre-commit.ci
Bodong-Yang
force-pushed
the
release/v1.0.1
branch
from
May 16, 2024 05:30
f84c0fb
to
a1cb170
Compare
Coverage Report
|
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This PR releases the new otaclient-iot-logging-server v1.0.1.
New feature
Logging filtering
Since otaclient iot-logger is expected to run on main ECU, now new iot-logger will parse the
ecu_info.yaml
file installed on the main ECU.Only loggings sent from known ECU ids will be accepted and upload to cloud.
Restart(by systemd) on config files changed
Warning
The restart is done by configured systemd service unit file, otaclient-logger itself can only kill itself on config files changed.
With Restart policy configured otaclient-logger systemd service unit file, otaclient-logger can restart itself(by systemd) on detecting any configuration files changed. Currently greengrass config(the in use one),
ecu_info.yaml
andaws_profile_info.yaml
files are monitored.Other Improvement & refinement
awsiot_credentialhelper
instead of pycurl, significantly reduce the dependency footprint and size, no more compilation during otaclient iot-logger installation.aws_profile_info.yaml
file instead of receiving params from command line.CI
Sonarcloud and pre-commit.ci are introduced to this repository.
The following pre-commit hooks are used:
otaclient iot-logger roles in autoware_ecu_system_setup
Since the package changed a lot, the corresponding ecu_system_setup role in ecu_system_setup is also updated.
Check
https://github.com/tier4/autoware_ecu_system_setup/tree/refine/new_otaclient%2Biot-logger/roles/ota_client_logger
for more details.Test files implementation
The unit tests for each components of the iot-logger have been implemented.
Real world test
The iot-logger implemented by this repository has been tested multiple times on the bench environment, and it all works without any problem.
See the following bench test for more details: