Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autoware_launch): update parameters #2

Merged
merged 5 commits into from
Mar 22, 2023
Merged

fix(autoware_launch): update parameters #2

merged 5 commits into from
Mar 22, 2023

Conversation

takayuki5168
Copy link

PR Type

  • Improvement

Related Links

Description

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

TakaHoribe and others added 5 commits March 22, 2023 16:54
@TakaHoribe @takayuki5168
[smoother] change curve speed params
fa3dc95 
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe @takayuki5168
[longitudinal_controller] disable smooth_stop to prevent stopping at …
8a65fd1 
…in front of the stop line

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@soblin @takayuki5168
only activate detection_area and lane change module in rtc_auto_manager
2da9c89 
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@rej55 @takayuki5168
fix(obstacle_stop_planner): fix lateral margin param
d1834fb 
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
@soblin @takayuki5168
fixed overrun at stop line by modifying delay compensation time
4046aa2 
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@takayuki5168 takayuki5168 changed the title Fix/tmp awf latest x1 fix(autoware_launch): update parameters Mar 22, 2023
@takayuki5168 takayuki5168 requested a review from kosuke55 March 22, 2023 08:01
@takayuki5168
Copy link
Author

@kosuke55 Please approve the PR.

@takayuki5168
Copy link
Author

@TakaHoribe @rej55 @kyoichi-sugahara Please approve the PR.

@takayuki5168 takayuki5168 merged commit 445e527 into awf-latest-x1 Mar 22, 2023
@takayuki5168 takayuki5168 deleted the fix/tmp-awf-latest-x1 branch March 22, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rej55 rej55 rej55 approved these changes

@kosuke55 kosuke55 Awaiting requested review from kosuke55

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@takayuki5168 @rej55 @TakaHoribe @soblin