Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

feat: add launch for vector map inside area filter #459

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

TomohitoAndo
Copy link
Contributor

@TomohitoAndo TomohitoAndo commented Aug 31, 2022

Signed-off-by: Tomohito Ando tomohito.ando@tier4.jp

PR Type

  • New Feature

Related Links

sync of the launcher with autoware.universe.

Description

I confirmed this works with pilot-auto.
image

Review Procedure

Please confirm the change is same as this PR.

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@TomohitoAndo TomohitoAndo marked this pull request as ready for review August 31, 2022 12:21
@TomohitoAndo TomohitoAndo requested a review from 0x126 August 31, 2022 12:21
Copy link
Contributor

@0x126 0x126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomohitoAndo TomohitoAndo merged commit defaa30 into awf-latest Sep 7, 2022
@TomohitoAndo TomohitoAndo deleted the add-vector-map-inside-area-filter branch September 7, 2022 00:38
takayuki5168 pushed a commit that referenced this pull request Jan 21, 2023
* Add simulator_launch package

* add argument

* fix depend order

* add argument

* move dummy_perception_publisher

* add arg for dummy_perception_publisher

* Update simulator_launch/launch/simulator.launch.xml

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants