Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

feat: modify name of occu grid map package #260

Merged
merged 1 commit into from
Apr 8, 2022
Merged

feat: modify name of occu grid map package #260

merged 1 commit into from
Apr 8, 2022

Conversation

yukkysaito
Copy link
Collaborator

@yukkysaito yukkysaito commented Apr 4, 2022 •
edited
Loading

Signed-off-by: Yukihiro Saito yukky.saito@gmail.com

PR Type

Related Links

autowarefoundation/autoware.universe#624

Description

Changed package name in response to this PR.

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@yukkysaito
feat: modify name of occu grid map package
7f5780a 
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
@yukkysaito yukkysaito requested a review from taikitanaka3 April 4, 2022 12:07
@taikitanaka3
Copy link
Contributor

@yukkysaito
can you change default method to point cloud base?

@yukkysaito
Copy link
Collaborator Author

@taikitanaka3 I would like to separate the PR 🙏

@yukkysaito yukkysaito requested review from aohsato and miursh April 8, 2022 05:57
taikitanaka3
taikitanaka3 approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yukkysaito yukkysaito merged commit e972b1b into tier4/universe Apr 8, 2022
@yukkysaito yukkysaito deleted the feature/mofify_occu_grid_map_package_name branch April 8, 2022 06:02
s-azumi pushed a commit to s-azumi/autoware_launch that referenced this pull request Apr 21, 2022
@kenji-miyake
Add global_params.launch.py (tier4#260)
30125e1 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
takayuki5168 pushed a commit that referenced this pull request May 26, 2022
@kk-inoue-esol @yn-mrse @hosokawa-ikuto
feat: add launch of rosbag logging mode changer (#260)
0784d66 
* add rosbag logging mode changer

* add rosbag logging mode changer

* remove extra launch

* add rosbag logging mode changer

* add logging_system launch

* remove duplicated parameters

Signed-off-by: kk-inoue-esol <kk-inoue@esol.co.jp>

* Moved system_launch/launch/logging_system.launch.xml into logging_launch/launch/logging_system.launch.xml and changed argument in system_launch/launch/system.launch.xml for the launch file moving.

Co-authored-by: Yuma Nihei <yuma.nihei@tier4.jp>
Co-authored-by: hosokawa <ikuto.hosokawa@tier4.jp>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@taikitanaka3 taikitanaka3 taikitanaka3 approved these changes

@aohsato aohsato Awaiting requested review from aohsato

@miursh miursh Awaiting requested review from miursh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yukkysaito @taikitanaka3