forked from autowarefoundation/autoware.universe
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(intersection): timeout static occlusion with traffic light #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n#5234) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…reas (autowarefoundation#5264) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
autowarefoundation#5304) * merge attention area lanelets topologically Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * query stop line for each merged detection lanelet Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * first conflicting/attention area Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * ignore expectedToStopBeforeStopLine vehicle Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * ignore expectedToStopBeforeStopLine vehicle Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * fix Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> --------- Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…warefoundation#5353) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
requested review from
shmpwk,
takayuki5168 and
tkimura4
as code owners
October 20, 2023 14:15
tkimura4
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!
念を押してlsimでテストしきったら僕の方でマージします! |
shmpwk
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
soblin
changed the title
intersectionのスタック防止
feat(intersection): timeout static occlusion with traffic light
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
autowarefoundation#5243
autowarefoundation#5264
autowarefoundation#5280
autowarefoundation#5304
autowarefoundation#5332
autowarefoundation#5353
のうち autowarefoundation#5353 (本PRのintersectionのスタック防止に関わる)以外についてはコードやデータ構造の変更だけ残して機能面の変更は削除
Related links
feature PR: https://github.com/tier4/autoware_launch.xx1/pull/678
Tests performed
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.