Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): set shuolder goal after loop #90

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

kosuke55
Copy link

@kosuke55 kosuke55 commented Aug 4, 2022

Signed-off-by: kosuke55 kosuke.tnp@gmail.com

Description

Fixed a problem with pull over mosule not working when goal is placed on shoulder lane after loop. This is just a workaround.
The problem is that the arc length cannot be calculated correctly, so this workaround will be considered in the lanelet function.

Related links

https://star4.slack.com/archives/CEV8XMJBV/p1659608990931289?thread_ts=1659523164.728609&cid=CEV8XMJBV

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 requested a review from tkimura4 August 4, 2022 13:05
@tkimura4
Copy link
Collaborator

tkimura4 commented Aug 4, 2022

** This is just a workaround. **

Before:
The behavior_path_planner threw errors and does not output the path in a following case.
image

After
The behavior_path_planner outputs the path properly.
image

Copy link
Collaborator

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit 16629dd into beta/v0.5.0 Aug 4, 2022
@tkimura4 tkimura4 deleted the tmp/fix_loop_sholuder_goal branch August 4, 2022 13:45
kosuke55 added a commit that referenced this pull request Aug 11, 2022
@kosuke55
Copy link
Author

Here is the main measure.
autowarefoundation#1571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants