Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pid_longitudinal_controller): several bug fix #868

Merged
merged 5 commits into from
Sep 26, 2023

Conversation

takayuki5168
Copy link

Description

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…alculation (autowarefoundation#5090)

* refactor(pid_longitudinal_controller): use common elevetation angle calculation

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
… manual driving (autowarefoundation#5092)

* fix(pid_longitudinal_controller): use is_autoware_control_enabled for manual driving

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
… the looser condition on manual driving (autowarefoundation#5093)

* feat(pid_longitudinal_controller): transit from emergency under the looser condition on manual driving

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add NOTE

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…oundation#5094)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 changed the title Feat/pid control improvement feat(pid_longitudinal_controller): several bug fix Sep 25, 2023
@takayuki5168 takayuki5168 assigned mkuri and unassigned mkuri Sep 25, 2023
@mkuri mkuri self-requested a review September 25, 2023 10:09
Copy link

@mkuri mkuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brkay54
Copy link

brkay54 commented Sep 26, 2023

@takayuki5168 Thank you for all the PRs, this one is the main PR, it won't be merged right?

@takayuki5168
Copy link
Author

@brkay54 This is an internal PR to tier4/autoware.universe.
The PR to awf/autoware.universe was already merged.

@takayuki5168 takayuki5168 merged commit bacf767 into beta/v0.11.0 Sep 26, 2023
@takayuki5168 takayuki5168 deleted the feat/pid-control-improvement branch September 26, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants