forked from autowarefoundation/autoware.universe
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(obstacle_stop): upd obstacle hunting #733
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>
Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>
Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>
Signed-off-by: Shigekazu Fukuta <shigekazu.fukuta@tier4.jp>
sfukuta
commented
Aug 16, 2023
sfukuta
commented
Aug 16, 2023
sfukuta
commented
Aug 18, 2023
sfukuta
commented
Aug 18, 2023
h-ohta
reviewed
Aug 28, 2023
h-ohta
reviewed
Aug 28, 2023
動き的には問題なさそうでした |
sfukuta
changed the title
feat(obstacle_stop) : upd obstacle hunting
feat(obstacle_stop): upd obstacle hunting
Aug 29, 2023
sfukuta
commented
Aug 30, 2023
@h-ohta PRのコメントについて、対応の確認をお願いします。 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
経路上の障害物検知した後に、障害物が移動た場合、停止線が移動した位置に対して再設定される。
その結果、停車・発車を繰り返すチャタリングが発生する問題がある。
本PRは、この問題を対策する。
※今回の対策は、OSSとして適応されている以下、PRを流用する形で適応する。
対策内容
これにより、障害物の移動によるチャタリングを回避する。
chattering_threshold
で設定する。(defalut : 0.5s)Related links
https://tier4.atlassian.net/browse/AEAP-465
https://github.com/tier4/autoware_launch.x1.eve/pull/419
Tests performed
機能検証
chattering_threshold
の設定値を、default値では機能検証が難しいため、5sに変更して確認を実施。chattering_threshol
で設定した時間)停止後に、再発車する事を確認済み(Psim)リグレッション評価
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.