Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane_departure_checker): add road boarder deparcher checker #729

Merged
merged 3 commits into from
Aug 20, 2023

Conversation

mkuri
Copy link

@mkuri mkuri commented Aug 16, 2023

Description

Add road boarder departure check

Related links

https://tier4.atlassian.net/browse/RT0-28542
https://tier4.atlassian.net/browse/RT1-3073

Tests performed

Confirmed on psim.
Not yet confirmed on actual vehicle.

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

kyoichi-sugahara and others added 2 commits August 16, 2023 08:29
…warefoundation#4607)

* temp

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* temp

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* temp

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* temp

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* update

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* add param

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* add param

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* update README.md

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* initialize variable

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix bug and output error messege

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* comment put debug message

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…n#4312)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added documentation Improvements or additions to documentation control common labels Aug 16, 2023
@mkuri mkuri changed the title Feature/add road boarder deparcher checker feat(lane_departure_checker): add road boarder deparcher checker Aug 16, 2023
@mkuri mkuri requested review from 0x126 and TomohitoAndo August 16, 2023 00:46
Copy link

@TomohitoAndo TomohitoAndo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkuri mkuri marked this pull request as ready for review August 20, 2023 12:58
@mkuri mkuri enabled auto-merge (squash) August 20, 2023 12:58
@mkuri mkuri disabled auto-merge August 20, 2023 12:58
Copy link

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for tier4_autoware_utils's change

@mkuri mkuri enabled auto-merge August 20, 2023 12:59
@mkuri mkuri merged commit 9f9d447 into beta/v0.9.1 Aug 20, 2023
@mkuri mkuri deleted the feature/add-road-boarder-deparcher-checker branch August 20, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common control documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants