Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(motion_velocity_smoother): add a diagnostic for smoothing failure #581

Merged

Conversation

mkuri
Copy link

@mkuri mkuri commented Jun 15, 2023

Description

Fixed a problem with slow deceleration when rapid deceleration is required

Related links

https://tier4.atlassian.net/browse/RT0-24965

Tests performed

  1. Spawn obstacles in front of the vehicle to rapid deceleration
  2. The diagnostics of "smoother_errors" is triggered and emergency stop is performed.

image
image

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

mkuri and others added 6 commits May 27, 2023 15:18
Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
Copy link

@0x126 0x126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x126 0x126 merged commit f93e66a into tier4:beta/v0.6.1 Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants