feat(motion_velocity_smoother): add a diagnostic for smoothing failure #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
0x126
requested review from
0x126 and
TomohitoAndo
and removed request for
rej55,
kenji-miyake and
ito-san
0x126
reviewed
Jun 14, 2023
planning/motion_velocity_smoother/config/default_motion_velocity_smoother.param.yaml
Outdated
Show resolved
Hide resolved
planning/motion_velocity_smoother/src/motion_velocity_smoother_node.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
|
修正後のソフトで動作確認ok |
0x126
approved these changes
Jun 15, 2023
Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
|
pre-commit.ci run |
auto-merge was automatically disabled
June 15, 2023 07:37
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed a problem with slow deceleration when rapid deceleration is required
Related links
https://tier4.atlassian.net/browse/RT0-24965
Tests performed
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.