Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_vehicle_rviz_plugin): fix build warning in Humble #451

Merged
merged 1 commit into from
May 15, 2023

Conversation

h-ohta
Copy link

@h-ohta h-ohta commented May 15, 2023

Description

https://github.com/autowarefoundation/autoware.universe/pull/852/files#diff-63a4e57abc1bb5508efbb58428d1a48ec1da6f91318ba8f2c836e2bd7784ec02R133 を参考にwarningを修正

Related Links

https://tier4.atlassian.net/browse/AEAP-488

Tests performed

以下のwarningが出ないこと

warning: ‘QPixmap QPixmap::transformed(const QMatrix&, Qt::TransformationMode) const’ is deprecated: Use transformed(const QTransform &, Qt::TransformationMode mode) [-Wdeprecated-declarations]

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link

@m-iwashita-esol m-iwashita-esol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/autowarefoundation/autoware.universe/pull/852/files#diff-63a4e57abc1bb5508efbb58428d1a48ec1da6f91318ba8f2c836e2bd7784ec02R133
の通り「transformed(QMatrix) is deprecated.」が正しく修正されている事を確認しました

@h-ohta h-ohta merged commit 62737e5 into beta/v0.3.16 May 15, 2023
@h-ohta h-ohta deleted the fix/tier4_vehicle_rviz branch May 15, 2023 03:57
@asa-naki asa-naki mentioned this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants