Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(launch): add COLCON_IGNORE #381

Merged
merged 2 commits into from
May 10, 2023
Merged

Conversation

h-ohta
Copy link

@h-ohta h-ohta commented Apr 26, 2023

Description

launch以下は不要なため、ビルドされないようにCOLCON_IGNOREを追加

related links

https://tier4.atlassian.net/browse/AEAP-485

Tests performed

$ cd ~/pilot-auto.x1.eve/src/autoware/launcher
$ grep . -r -e tier4_.*_launch --exclude-dir .git -l

で何もでてこないことを確認
つまり、autoware_launch内で呼ばれていないことを確認

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-ohta h-ohta marked this pull request as ready for review April 28, 2023 07:00
@h-ohta h-ohta changed the base branch from beta/v0.3.15 to beta/v0.3.16 May 8, 2023 08:48
@h-ohta h-ohta changed the title chore(launch): add COLCON_IGNORE feat(launch): add COLCON_IGNORE May 9, 2023
Copy link

@v-nojiri7841-esol v-nojiri7841-esol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

以下の依存があるものの、ランタイムエラー時にsystem_monitor側を直す方針のため、Approveします。

VSCODEの検索にて、以下で検索する。

設定項目 設定値
検索ワード tier4_[a-zA-Z0-9]*_launch
files to include ./src
files to exclude ./src/autoware/universe/launch/

次の依存が1件見つかる。

src/autoware/universe/system/system_monitor/launch/system_monitor.launch.py:
  121      system_monitor_path = os.path.join(
  122:         get_package_share_directory("tier4_system_launch"), "config", "system_monitor"
  123      )
※他の検索結果はすべてmdファイル。

ランタイムエラーとなった場合は、system_monitorのデフォルト値を修正する流れで進めるため、Approveする。

@h-ohta h-ohta merged commit 514381f into beta/v0.3.16 May 10, 2023
@h-ohta h-ohta deleted the feat/colcon_ignore_launch branch May 10, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants