ci(dispatch-release-note): use Github Apps instead of GIHUB_TOKEN #315

shmpwk · 2023-03-13T00:54:36Z

Description

We mostly cannot dispatch workflow with GITHUB_TOKEN.
Instead, we often use Github Apps for organization authorization.
This PR is a substitue for #314

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

shmpwk · 2023-03-13T01:09:15Z

@kenji-miyake
Could you check the authorization scope of Github Apps if it can trigger the other repository(= https://github.com/tier4/update-release-notes)?
Currently, the dispatch is failed because of 404 https://github.com/tier4/autoware.universe/actions/runs/4400367753/jobs/7705601385

kenji-miyake · 2023-03-13T01:25:39Z

@shmpwk I've asked the org admin to add you to the App admin.

shmpwk · 2023-03-13T08:54:30Z

@kenji-miyake
Thank you, I succeeded to add read and write access for Actions and Contents.
https://github.com/organizations/tier4/settings/apps/tier4-autoware-public-bot/permissions
However the dispatch is still failed.
Do you have an insight for this?

kenji-miyake · 2023-03-13T10:36:21Z

@shmpwk Mm, I'm sorry I have no idea. 😢

kenji-miyake · 2023-03-13T11:49:48Z

@shmpwk I think your request weren't approved yet. Could you try it again?

shmpwk · 2023-03-14T00:32:18Z

@kenji-miyake
Thank you for your approval, but still it is failed.
I continue to investigate the cause of the 404.

shmpwk · 2023-03-14T02:34:46Z

@kenji-miyake
I confirmed that dispatch succeeded !

dispatch from
- https://github.com/tier4/autoware.universe/actions/runs/4410875614/jobs/7730258877-
dispatched workflow
- https://github.com/tier4/update-release-notes/actions/runs/4411598287

The cause of the problem is that I haven't completed to install Github Apps at dipatched workflow.

Thank you for your help!

shmpwk · 2023-03-14T04:33:20Z

Thank you for modifying spell

shmpwk · 2023-03-14T04:46:24Z

I mistakenly merged the tier4/main branch and asked many people to review.
Now I reset the commits but sorry for bothering you.

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

shmpwk · 2023-03-14T05:11:24Z

I've messed up commanding the git operations, but it looks like everything is ready to go now.

* ci(dispatch-release-note): use Github Apps instead of GIHUB_TOKEN Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> * fix typo * chore: remove white space Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> --------- Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* ci: dispatch release note repository (#313) Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> * ci(dispatch-release-note): use Github Apps instead of GIHUB_TOKEN (#315) * ci(dispatch-release-note): use Github Apps instead of GIHUB_TOKEN Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> * fix typo * chore: remove white space Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> --------- Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> --------- Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* ci(dispatch-release-note): use Github Apps instead of GIHUB_TOKEN Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> * fix typo * chore: remove white space Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> --------- Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* ci: dispatch release note repository (#313) Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> * ci(dispatch-release-note): use Github Apps instead of GIHUB_TOKEN (#315) * ci(dispatch-release-note): use Github Apps instead of GIHUB_TOKEN Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> * fix typo * chore: remove white space Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> --------- Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> --------- Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

ci(dispatch-release-note): use Github Apps instead of GIHUB_TOKEN

bb30be3

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

github-actions bot added the ci label Mar 13, 2023

shmpwk mentioned this pull request Mar 13, 2023

ci(dispatch-release-note): use PAT instead of GITHUB_TOKEN #314

Closed

4 tasks

shmpwk requested a review from kenji-miyake March 13, 2023 01:05

shmpwk marked this pull request as ready for review March 13, 2023 01:05

fix typo

82eece9

shmpwk requested review from ito-san, amc-nu, miursh, yukkysaito, rej55, taikitanaka3, maxime-clem, kosuke55, takayuki5168, satoshi-ota, TakaHoribe, tkimura4, purewater0901, zulfaqar-azmi-t4, wep21 and manato as code owners March 14, 2023 04:39

shmpwk removed request for soblin, kyoichi-sugahara, miursh, kosuke55, wep21, purewater0901, satoshi-ota, ito-san, tkimura4, taikitanaka3, maxime-clem and zulfaqar-azmi-t4 March 14, 2023 04:44

chore: remove white space

ec9902d

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

shmpwk force-pushed the ci/github-apps-dispatch branch from 2ed0fee to ec9902d Compare March 14, 2023 04:57

kenji-miyake approved these changes Mar 14, 2023

View reviewed changes

shmpwk merged commit 057d0da into tier4:tier4/main Mar 14, 2023

shmpwk deleted the ci/github-apps-dispatch branch March 14, 2023 08:58

shmpwk mentioned this pull request Apr 5, 2023

ci: dispatch release note tier4/autoware_launch#29

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci(dispatch-release-note): use Github Apps instead of GIHUB_TOKEN #315

ci(dispatch-release-note): use Github Apps instead of GIHUB_TOKEN #315

shmpwk commented Mar 13, 2023 •

edited by kenji-miyake

Loading

shmpwk commented Mar 13, 2023 •

edited

Loading

kenji-miyake commented Mar 13, 2023

shmpwk commented Mar 13, 2023 •

edited

Loading

kenji-miyake commented Mar 13, 2023

kenji-miyake commented Mar 13, 2023

shmpwk commented Mar 14, 2023 •

edited

Loading

shmpwk commented Mar 14, 2023

shmpwk commented Mar 14, 2023

shmpwk commented Mar 14, 2023 •

edited

Loading

shmpwk commented Mar 14, 2023

ci(dispatch-release-note): use Github Apps instead of GIHUB_TOKEN #315

ci(dispatch-release-note): use Github Apps instead of GIHUB_TOKEN #315

Conversation

shmpwk commented Mar 13, 2023 • edited by kenji-miyake Loading

Description

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

shmpwk commented Mar 13, 2023 • edited Loading

kenji-miyake commented Mar 13, 2023

shmpwk commented Mar 13, 2023 • edited Loading

kenji-miyake commented Mar 13, 2023

kenji-miyake commented Mar 13, 2023

shmpwk commented Mar 14, 2023 • edited Loading

shmpwk commented Mar 14, 2023

shmpwk commented Mar 14, 2023

shmpwk commented Mar 14, 2023 • edited Loading

shmpwk commented Mar 14, 2023

shmpwk commented Mar 13, 2023 •

edited by kenji-miyake

Loading

shmpwk commented Mar 13, 2023 •

edited

Loading

shmpwk commented Mar 13, 2023 •

edited

Loading

shmpwk commented Mar 14, 2023 •

edited

Loading

shmpwk commented Mar 14, 2023 •

edited

Loading