Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): fix path distortion of no back pull out (#2829) #273

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

tkimura4
Copy link
Collaborator

@tkimura4 tkimura4 commented Feb 7, 2023

Description

autowarefoundation#2829
Hotfix to beta/v0.7.0

Fix path distortion of pull out path when backward driving is disabled.
The geometric pull out assumes that the start pose and the end pose is in parallel, but when backward driving is disabled the raw current pose is used as start pose and is not refined. In this PR, the current pose is refined to the lane for the start pose.
And add a guard for discontinuity.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…utowarefoundation#2829)

* fix(behavior_path_planner): fix path distortion of no back pull out

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/utils/geometric_parallel_parking.cpp

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@codecov-commenter
Copy link

Codecov Report

Base: 0.00% // Head: 2.82% // Increases project coverage by +2.82% 🎉

Coverage data is based on head (31a8864) compared to base (8c23304).
Patch coverage: 0.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@              Coverage Diff               @@
##           beta/v0.7.0    #273      +/-   ##
==============================================
+ Coverage         0.00%   2.82%   +2.82%     
==============================================
  Files                9      70      +61     
  Lines              793    8733    +7940     
  Branches             0    4165    +4165     
==============================================
+ Hits                 0     247     +247     
- Misses             793    8274    +7481     
- Partials             0     212     +212     
Flag Coverage Δ
differential 2.82% <0.00%> (+2.82%) ⬆️
Impacted Files Coverage Δ
..._planner/scene_module/pull_out/pull_out_module.hpp 0.00% <ø> (ø)
...nner/src/scene_module/pull_out/pull_out_module.cpp 0.00% <0.00%> (ø)
.../scene_module/utils/geometric_parallel_parking.cpp 0.00% <0.00%> (ø)
...clude/object_detection/tracked_objects_display.hpp
...n/src/object_detection/tracked_objects_display.cpp
...gin/src/object_detection/object_polygon_detail.cpp
.../src/object_detection/detected_objects_display.cpp
...e/object_detection/object_polygon_display_base.hpp
...ude/object_detection/predicted_objects_display.hpp
...src/object_detection/predicted_objects_display.cpp
... and 72 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@1222-takeshi 1222-takeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit b481bd6 into beta/v0.7.0 Feb 8, 2023
@tkimura4 tkimura4 deleted the fix/pull_out_no_back branch February 8, 2023 02:40
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants