Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_stop_planner): add hold stop margin distance (backport #1434) #210

Merged
merged 4 commits into from
Jun 21, 2023

Conversation

yn-mrse
Copy link

@yn-mrse yn-mrse commented Dec 19, 2022

Description

back port autowarefoundation#1434

  • 一部motion_utils由来の関数をtier4_autoware_utilsへ置き換えています。 c1a954e

Test performed

リグレッション確認済み

  • planning simulatorにて、障害物に対する停車挙動および、障害物撤去時の再発車挙動が既存と同一であることを確認しました。

※事前に #592#594 をマージする必要があります。

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-ohta h-ohta changed the base branch from beta/v0.3.13 to beta/v0.3.14 March 17, 2023 06:00
@h-ohta h-ohta changed the base branch from beta/v0.3.14 to beta/v0.3.16 May 11, 2023 07:16
@yn-mrse yn-mrse changed the base branch from beta/v0.3.16 to feat/keep_stopping_dist/v0.3.16 June 20, 2023 05:03
@yn-mrse yn-mrse force-pushed the backport/pr1434/v0.3.13 branch from fcd7418 to 90f31b4 Compare June 20, 2023 06:50
@yn-mrse yn-mrse force-pushed the backport/pr1434/v0.3.13 branch from d9dcfe5 to f8e5249 Compare June 20, 2023 12:56
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2023

Codecov Report

❗ No coverage uploaded for pull request base (feat/keep_stopping_dist/v0.3.16@76b20f9). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@                        Coverage Diff                        @@
##             feat/keep_stopping_dist/v0.3.16    #210   +/-   ##
=================================================================
  Coverage                                   ?   0.00%           
=================================================================
  Files                                      ?       4           
  Lines                                      ?    1153           
  Branches                                   ?       0           
=================================================================
  Hits                                       ?       0           
  Misses                                     ?    1153           
  Partials                                   ?       0           
Flag Coverage Δ
differential 0.00% <0.00%> (?)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

satoshi-ota and others added 2 commits June 21, 2023 12:18
* feat(obstacle_stop_planner): add hold stop margin distance

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(obstacle_stop_planner): output distance info

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(obstacle_stop_planner): add param into config

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@yn-mrse yn-mrse force-pushed the backport/pr1434/v0.3.13 branch from 2364b69 to c1a954e Compare June 21, 2023 03:20
@yn-mrse yn-mrse requested a review from sfukuta June 21, 2023 03:21
@sfukuta
Copy link

sfukuta commented Jun 21, 2023

@yn-mrse リグレッションで確認した内容について、記載をお願いします。

@yn-mrse yn-mrse merged commit 0a72a37 into feat/keep_stopping_dist/v0.3.16 Jun 21, 2023
@yn-mrse yn-mrse deleted the backport/pr1434/v0.3.13 branch June 21, 2023 08:55
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Feb 7, 2024
* ci: add github-release.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add workflow_dispatch

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add inputs for workflow_dispatch

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* support beta branches

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants