Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_traffic_light_arbiter): add current time validation (#9… #1880

Open
wants to merge 1 commit into
base: beta/x2_gen2/v0.29.2
Choose a base branch
from

Conversation

v-kakami60210-esol
Copy link

@v-kakami60210-esol v-kakami60210-esol commented Mar 3, 2025

Description

autowarefoundation/autoware.universe#9747をcherry-pickする。
※X2のv4.1.x系統には最新からのSyncで取り込まれるが、4.0.x系統には取り込まれていないので取り込む。

Related links

Parent Issue:

同時に取り込みが必要なPR:

How was this PR tested?

Planning simulatorとEvaluatorで実施。

  • Planning simulator
    • 信号を通過する経路で走行できることを確認。
  • Evaluator
    • 大幅なOK/NG増減もないことから、デグレなく取りこめていると判断する。
テスト対象 OK NG 総数
比較元 2143 472 2615
今回の実行結果 2128 487 2615

比較結果
https://evaluation.tier4.jp/evaluation/reports/tables/new?catalog_id=fb623cde-1fbd-413b-a79d-548b27113dd1&filter=&job_id=0dd36591-500e-5dde-8879-f3dfe2376447&project_id=x2_dev&table_config=date&target_ids=60838c81-3d59-5bef-8828-65d5fa467181

Notes for reviewers

actions/upload-artifactのバージョンが非推奨のためCI/CDチェックに失敗した。
今回のPR内容が原因ではないので未修正。

Interface changes

None.

Effects on system behavior

None.

…towarefoundation#9747)

* add current time validation

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

* style(pre-commit): autofix

* change ros parameter name

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

* style(pre-commit): autofix

* add validation with absolute function

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

* add timestamp of topic in test

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

* fix ci error

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

---------

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: v-kakami60210-esol <v-kakami60210@esol.co.jp>
Copy link

sonarqubecloud bot commented Mar 3, 2025

@v-kakami60210-esol v-kakami60210-esol marked this pull request as ready for review March 3, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant