Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(reaction_analyzer): fix include hierarchy of tf2_eigen (#8663) #1531

Closed
wants to merge 1 commit into from
Closed

fix(reaction_analyzer): fix include hierarchy of tf2_eigen (#8663) #1531

wants to merge 1 commit into from

Conversation

Owen-Liuyuxuan
Copy link

Fixed include hierarchy of tf2_eigen. Hotfix into main

Description

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@SakodaShintaro @Owen-Liuyuxuan
fix(reaction_analyzer): fix include hierarchy of tf2_eigen (autowaref…
8ab379c 
…oundation#8663)

Fixed include hierarchy of tf2_eigen

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: YuxuanLiuTier4Desktop <619684051@qq.com>
@Owen-Liuyuxuan
Copy link
Author

@SakodaShintaro It seems that the DCO problem needs to be fixed by your commit.

@SakodaShintaro
Copy link

@Owen-Liuyuxuan
Sorry, as I understand, it is not the practice to directly apply a hotfix to the tier4/main branch.
Could you explain the reason for needing this hotfix?

@rej55
Please feel free to correct me if I am mistaken.

@Owen-Liuyuxuan
Copy link
Author

Owen-Liuyuxuan commented Sep 10, 2024 •
edited
Loading

Because the down-stream pilot-auto.xx1/main also relies on this main; we have been stuck for quite a long time (more than a month) to make pilot-auto.xx1/main buildable.

If tier4/main does not build correctly on its own, the deployment process stating that tier4/main as a "stable" branch does not make much sense.

@rej55
Copy link
Collaborator

rej55 commented Sep 10, 2024

tier4/main will be synced with stable pilot-auto version.
The latest version v0.34.0, which includes this change, will be released soon.

@Owen-Liuyuxuan Could you wait for release v0.34.0?

@Owen-Liuyuxuan
Copy link
Author

pilot-auto.xx1 has failed the integration process from v0.32.0 up to now as far as I understand.

@Owen-Liuyuxuan Owen-Liuyuxuan deleted the fix_tf2_eigen branch September 10, 2024 08:38
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SakodaShintaro SakodaShintaro Awaiting requested review from SakodaShintaro

@rej55 rej55 Awaiting requested review from rej55

@Naophis Naophis Awaiting requested review from Naophis

Assignees
No one assigned
Labels
component:tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Owen-Liuyuxuan @SakodaShintaro @rej55