Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dummy_diag_publisher): not use diagnostic_updater and param callback #1272

Merged
merged 3 commits into from
May 8, 2024

Conversation

h-ohta
Copy link

@h-ohta h-ohta commented Apr 24, 2024

Description

  • diagnostic_updaterを使用するとdiagのnameにノード名が入ってしまうため、自前でpublishする形に変更する
  • param callbackを削除する
    • 正常に動いていなかったため、
    • パラメータでdefaultを設定する都合上、正常に動いたとしてもdefault指定の場合はパラメータを変更できないため

Related links

https://tier4.atlassian.net/browse/RT0-31356

Tests performed

https://github.com/tier4/autoware_launch.x2/pull/641 と一緒に確認する

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-ohta h-ohta marked this pull request as ready for review May 8, 2024 01:34
@h-ohta h-ohta requested review from ito-san and TetsuKawa as code owners May 8, 2024 01:34
Copy link

@ito-san ito-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@h-ohta LGTMなんですが、pre-commit.ciで関係ないところでエラーが出てますね...

@ito-san ito-san added the enhancement New feature or request label May 8, 2024
@h-ohta
Copy link
Author

h-ohta commented May 8, 2024

@ito-san このPRで直すのもおかしいので、別でPR作ります

@h-ohta h-ohta mentioned this pull request May 8, 2024
7 tasks
@h-ohta
Copy link
Author

h-ohta commented May 8, 2024

@ito-san 無事CIが通ったみたいですね

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants