Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(raw_vehicle_cmd_converter): csv paths are resolved in param.yaml #1240

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

zhiwango
Copy link

@zhiwango zhiwango commented Apr 10, 2024

…(autowarefoundation#6476)

Description

accel_map.csv, brake_map.csv, steer_map.csvのパス設定はyamlファイルに移動した。
autowarefoundation/autoware.universe側のPRをcherry-pickしました。

Related links

autowarefoundation#6476

Tests performed

ros2 launch j6_gen1_launch vehicle_interface.launch.xml で起動すると、map_pathが正しく読み込んでいることは確認できました。

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@zhiwango zhiwango merged commit 10a8dce into beta/v0.19.1 Apr 10, 2024
16 of 18 checks passed
@zhiwango zhiwango deleted the feat/raw-vehicle-cmd-csv-path branch April 10, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants