Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bag time manager): add to beta v0.5.2 #108

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

taikitanaka3
Copy link

Description

awf: (autowarefoundation#1776)

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…utowarefoundation#1776)

* feat(bag_timemanager): add bag time manager rviz plugin

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: fix change

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Copy link
Collaborator

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2022

Codecov Report

❗ No coverage uploaded for pull request base (beta/v0.5.2@6c73362). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             beta/v0.5.2    #108   +/-   ##
=============================================
  Coverage               ?   0.00%           
=============================================
  Files                  ?       1           
  Lines                  ?      52           
  Branches               ?       0           
=============================================
  Hits                   ?       0           
  Misses                 ?      52           
  Partials               ?       0           
Flag Coverage Δ
differential 0.00% <0.00%> (?)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tkimura4 tkimura4 merged commit 7ffc17b into beta/v0.5.2 Sep 6, 2022
@tkimura4 tkimura4 deleted the feature/bag_time_manager_beta_v0.5.2 branch September 6, 2022 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants