Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(simple_planning_simulator): fix ego sign pitch problem (#5616) #1029

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

h-ohta
Copy link

@h-ohta h-ohta commented Nov 21, 2023

Description

autowarefoundation#5616 のbackport

Related links

https://tier4.atlassian.net/browse/RT0-29756

Tests performed

  • 変更内容に問題ないことを目視で確認した

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…oundation#5616)

* fix ego sign pitch problem

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* change variable name for clarity

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* update documentation to clarify that driving against the lane is not supported

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
@github-actions github-actions bot added documentation Improvements or additions to documentation simulator labels Nov 21, 2023
@h-ohta h-ohta marked this pull request as ready for review November 21, 2023 06:42
@h-ohta h-ohta requested review from 0x126 and TomohitoAndo November 21, 2023 06:42
Copy link

@TomohitoAndo TomohitoAndo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-ohta h-ohta merged commit f30f4c8 into beta/v0.11.1 Nov 21, 2023
15 checks passed
@h-ohta h-ohta deleted the backport/5616 branch November 21, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation simulator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants