Skip to content

Commit

Permalink
Revert "fix(multi_object_tracker): bicycle motion model - set minimum…
Browse files Browse the repository at this point in the history
… wheel-to-center length (autowarefoundation#6337)"

This reverts commit 7a53913.
  • Loading branch information
kminoda committed Feb 8, 2024
1 parent 2851b2f commit 5efab29
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,8 @@ BicycleTracker::BicycleTracker(
ekf_.init(X, P);

// Set lf, lr
lf_ = std::max(bounding_box_.length * 0.3, 0.3); // 30% front from the center, minimum of 0.3m
lr_ = std::max(bounding_box_.length * 0.3, 0.3); // 30% rear from the center, minimum of 0.3m
lf_ = bounding_box_.length * 0.3; // 30% front from the center
lr_ = bounding_box_.length * 0.3; // 30% rear from the center
}

bool BicycleTracker::predict(const rclcpp::Time & time)
Expand Down Expand Up @@ -425,8 +425,8 @@ bool BicycleTracker::measureWithShape(
bbox_object.shape.dimensions.x, bbox_object.shape.dimensions.y, bbox_object.shape.dimensions.z};

// update lf, lr
lf_ = std::max(bounding_box_.length * 0.3, 0.3); // 30% front from the center, minimum of 0.3m
lr_ = std::max(bounding_box_.length * 0.3, 0.3); // 30% rear from the center, minimum of 0.3m
lf_ = bounding_box_.length * 0.3; // 30% front from the center
lr_ = bounding_box_.length * 0.3; // 30% rear from the center

return true;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,8 @@ BigVehicleTracker::BigVehicleTracker(
setNearestCornerOrSurfaceIndex(self_transform); // this index is used in next measure step

// Set lf, lr
lf_ = std::max(bounding_box_.length * 0.3, 1.5); // 30% front from the center, minimum of 1.5m
lr_ = std::max(bounding_box_.length * 0.25, 1.5); // 25% rear from the center, minimum of 1.5m
lf_ = bounding_box_.length * 0.3; // 30% front from the center
lr_ = bounding_box_.length * 0.25; // 25% rear from the center
}

bool BigVehicleTracker::predict(const rclcpp::Time & time)
Expand Down Expand Up @@ -457,8 +457,9 @@ bool BigVehicleTracker::measureWithShape(
bbox_object.shape.dimensions.x, bbox_object.shape.dimensions.y, bbox_object.shape.dimensions.z};

// update lf, lr
lf_ = std::max(bounding_box_.length * 0.3, 1.5); // 30% front from the center, minimum of 1.5m
lr_ = std::max(bounding_box_.length * 0.25, 1.5); // 25% rear from the center, minimum of 1.5m
lf_ = bounding_box_.length * 0.3; // 30% front from the center
lr_ = bounding_box_.length * 0.25; // 25% rear from the center

return true;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,8 @@ NormalVehicleTracker::NormalVehicleTracker(
setNearestCornerOrSurfaceIndex(self_transform); // this index is used in next measure step

// Set lf, lr
lf_ = std::max(bounding_box_.length * 0.3, 1.0); // 30% front from the center, minimum of 1.0m
lr_ = std::max(bounding_box_.length * 0.25, 1.0); // 25% rear from the center, minimum of 1.0m
lf_ = bounding_box_.length * 0.3; // 30% front from the center
lr_ = bounding_box_.length * 0.25; // 25% rear from the center
}

bool NormalVehicleTracker::predict(const rclcpp::Time & time)
Expand Down Expand Up @@ -457,8 +457,8 @@ bool NormalVehicleTracker::measureWithShape(
bbox_object.shape.dimensions.x, bbox_object.shape.dimensions.y, bbox_object.shape.dimensions.z};

// update lf, lr
lf_ = std::max(bounding_box_.length * 0.3, 1.0); // 30% front from the center, minimum of 1.0m
lr_ = std::max(bounding_box_.length * 0.25, 1.0); // 25% rear from the center, minimum of 1.0m
lf_ = bounding_box_.length * 0.3; // 30% front from the center
lr_ = bounding_box_.length * 0.25; // 25% rear from the center

return true;
}
Expand Down

0 comments on commit 5efab29

Please sign in to comment.