Skip to content
This repository has been archived by the owner on Sep 16, 2022. It is now read-only.

Fix before/after line of virtual_traffic_light #795

Closed

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Dec 27, 2021

Description

This PR is cherry-pick of https://github.com/tier4/autoware.iv/pull/2413.

  • Added margin to isBeforeStopLine
  • Shared parameters with isNearAnyEndLine and isNearAnyEndLine.
  • Fixed the bool value of isStateTimeout
  • Modified to check the timeout even after exceeding the stop line as default

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the guidelines.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Copy link
Contributor

@kenji-miyake kenji-miyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Could you please send a PR to autoware.universe as well? 🙏
cc @wep21

@kosuke55
Copy link
Contributor Author

kosuke55 commented Jan 18, 2022

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants