Skip to content
This repository has been archived by the owner on Sep 16, 2022. It is now read-only.

add verb and loop counter for check #771

Merged
merged 4 commits into from
Dec 10, 2021

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Dec 9, 2021

Description

add more details for gtest
sync
autowarefoundation/autoware.universe#147

Review Procedure

see CI resutl

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the guidelines.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@kenji-miyake kenji-miyake marked this pull request as draft December 9, 2021 03:49
@kenji-miyake
Copy link
Contributor

Seems it has timed out.

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@taikitanaka3 taikitanaka3 marked this pull request as ready for review December 10, 2021 05:04
Copy link
Contributor

@1222-takeshi 1222-takeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@1222-takeshi 1222-takeshi self-requested a review December 10, 2021 05:11
1222-takeshi
1222-takeshi previously approved these changes Dec 10, 2021
@1222-takeshi
Copy link
Contributor

@taikitanaka3
Please check here.

@1222-takeshi 1222-takeshi dismissed their stale review December 10, 2021 05:17

cancel approve

@1222-takeshi
Copy link
Contributor

@taikitanaka3
Please add this PR.
autowarefoundation/autoware.universe#156

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@taikitanaka3 taikitanaka3 enabled auto-merge (squash) December 10, 2021 07:58
Copy link
Contributor

@1222-takeshi 1222-takeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taikitanaka3 taikitanaka3 merged commit d4ecd7d into use-autoware-auto-msgs Dec 10, 2021
@taikitanaka3 taikitanaka3 deleted the auto/fix_gtest branch December 10, 2021 08:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants