-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog post for pillar 1.2.1 #121
Conversation
I think it might be easier for people to understand if you just use |
Thanks. Would you agree to an explanatory note? It seems that ansistrings can currently render pillar output but not tibble output (r-lib/ansistrings#14), and I'd rather avoid taking screenshots again. |
Why is tibble not generated balanced escapes? I'd really prefer to keep the blog post focussed on tibble, not on incidental details that most people won't care about. |
tibble uses nested crayon styles which are implemented with escape codes. I might be able to work around this in tibble. |
Changed examples to use tibble, added a clarification section to the bottom: https://deploy-preview-121--tidyverse-org.netlify.com/articles/2018/03/pillar-1-2-1/. Let's wait until Friday (the anticipated date of the blog post), binaries should be built by then. |
FYI I needed this tweak to colourise_chunk <- function(type) {
function(x, options) {
x <- pkgdown:::escape_html(x)
x <- ansistrings::ansi_to_html(x, fullpage = FALSE)
class <- tolower(options$engine)
sprintf('<pre class="knitr %s">%s</pre>\n', class, x)
}
} It escapes HTML syntax which is necessary for printing stuff like |
Thanks. I'm already using |
oops sorry I must have been confused while debugging and somehow got rid of |
All binaries have been built on CRAN, ready to publish? |
Published, thanks! |
@hadley: This requires a hotfix to be pushed to CRAN, to fix lubridate. I think the coloring of negative decimal numbers is wrong too.
Preview link: https://5a943d98efbe5d6bd34765fe--tidyverse-org.netlify.com/articles/2018/03/pillar-1-2-1/.