Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .by syntax in pivot_wider dplyr helper message #1529

Merged
merged 4 commits into from
Nov 4, 2023

Conversation

boshek
Copy link
Contributor

@boshek boshek commented Nov 1, 2023

Closes #1516

Uses .by syntax in helper message

@hadley
Copy link
Member

hadley commented Nov 2, 2023

Looks great! Since you're touching this code, do you think it's worth switching to |> too?

@boshek
Copy link
Contributor Author

boshek commented Nov 2, 2023

Ah yes, good idea.

Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you please add a bullet to the top of NEWS.md? It should briefly describe the change and end with (@yourname, #issuenumber).

@hadley hadley merged commit 4afb8ca into tidyverse:main Nov 4, 2023
13 checks passed
@hadley
Copy link
Member

hadley commented Nov 4, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider changing dplyr suggestion in pivot_wider to use .by
2 participants