-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra boxplot features #5423
Merged
Merged
Extra boxplot features #5423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've removed these extra settings as aesthetics and instead added them as fixed parameters. To reproduce the previous boxplot, one can now use: devtools::load_all("~/packages/ggplot2")
#> ℹ Loading ggplot2
#> Warning: package 'testthat' was built under R version 4.3.1
ggplot(mpg, aes(class, displ, colour = class)) +
geom_boxplot(
box.colour = "black",
staple.colour = "black",
staple.linewidth = 1,
whisker.linetype = 2,
staplewidth = 0.5
) Created on 2023-10-27 with reprex v2.0.2 |
thomasp85
reviewed
Sep 13, 2024
Merge branch 'main' into boxplot_features # Conflicts: # R/geom-boxplot.R
thomasp85
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #5126 and fix #3459.
Briefly, it adds 9 new aesthetics to
geom_boxplot()
to set the colour, linewidth and linetype for whiskers, staples and median line.These all work by setting the default as
NULL
and then inheriting from the maincolour
,linewidth
orlinetype
if not set explicitly.I'm still unsure about some decisions, so that is why this PR is marked work in progress (WIP). Some considerations:
geom_crossbar()
to get them to work in the boxplot. Should we include these as aesthetics togeom_crossbar()
as well? If yes, ismedian_{aes}
appropriate, or ismiddle_{aes}
more appropriate?outlier.colour
)? If they should be fixed, the scale interaction point below becomes moot.scale_colour_hue(aesthetics = "median_colour")
is also a bit of pain for the user. In addition,scale_linewidth_*()
andscale_linetype_*()
scales don't expose theaesthetics
argument, so there isn't really a way to scale these.box_colour
,box_linewidth
andbox_linetype
?A demonstration:
Created on 2023-09-15 with reprex v2.0.2